<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Coordinated Graphics] Improve scheduling of tasks between threads in CoordinatedGraphicsScene"
href="https://bugs.webkit.org/show_bug.cgi?id=160238">bug 160238</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #284684 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Coordinated Graphics] Improve scheduling of tasks between threads in CoordinatedGraphicsScene"
href="https://bugs.webkit.org/show_bug.cgi?id=160238#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Coordinated Graphics] Improve scheduling of tasks between threads in CoordinatedGraphicsScene"
href="https://bugs.webkit.org/show_bug.cgi?id=160238">bug 160238</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=284684&action=diff" name="attach_284684" title="Patch">attachment 284684</a> <a href="attachment.cgi?id=284684&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=284684&action=review">https://bugs.webkit.org/attachment.cgi?id=284684&action=review</a>
Questions
<span class="quote">> Source/WebKit2/ChangeLog:12
> + - Use Function instead of std::function on dispatch methods.</span >
Why, just to use our thing instead of the standard one? Is there an advantage to WTF::Function?
<span class="quote">> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:44
> + RunLoop::main().dispatch([protectedThis = makeRef(*this), function = WTFMove(function)] {</span >
Why is this correct? We don't use |this| inside the lambda, so why the need to keep it alive? If the ref is really needed then it should be handled inside |function|, right?
<span class="quote">> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:56
> + m_clientRunLoop.dispatch([protectedThis = makeRef(*this), function = WTFMove(function)] {</span >
Ditto.
<span class="quote">> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:158
> + dispatchOnClientRunLoop([this] {</span >
Why no protector?
<span class="quote">> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:622
> + dispatchOnMainThread([this] {</span >
Ditto.
<span class="quote">> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:689
> + dispatchOnMainThread([this, layerID, offset] {</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>