<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Coordinated Graphics] Improve scheduling of tasks between threads in CoordinatedGraphicsScene"
href="https://bugs.webkit.org/show_bug.cgi?id=160238#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Coordinated Graphics] Improve scheduling of tasks between threads in CoordinatedGraphicsScene"
href="https://bugs.webkit.org/show_bug.cgi?id=160238">bug 160238</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=160238#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=284684&action=diff" name="attach_284684" title="Patch">attachment 284684</a> <a href="attachment.cgi?id=284684&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=284684&action=review">https://bugs.webkit.org/attachment.cgi?id=284684&action=review</a>
>
> Questions
>
> > Source/WebKit2/ChangeLog:12
> > + - Use Function instead of std::function on dispatch methods.
>
> Why, just to use our thing instead of the standard one? Is there an
> advantage to WTF::Function?</span >
This is WTF::Function.
<span class="quote">> > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:44
> > + RunLoop::main().dispatch([protectedThis = makeRef(*this), function = WTFMove(function)] {
>
> Why is this correct? We don't use |this| inside the lambda, so why the need
> to keep it alive? If the ref is really needed then it should be handled
> inside |function|, right?</span >
Just to ensure the scene is alive, that's why it's called protectedThis. Before this patch all caller do that themselves, and in some cases unnecessarily, because we only need it when scheduling to another thread. Now it's done here to simplify the callers.
<span class="quote">> > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:56
> > + m_clientRunLoop.dispatch([protectedThis = makeRef(*this), function = WTFMove(function)] {
>
> Ditto.</span >
Ditto.
<span class="quote">> > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:158
> > + dispatchOnClientRunLoop([this] {
>
> Why no protector?</span >
Because dispatchOnClientRunLoop is protecting this only when actually needed.
<span class="quote">> > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:622
> > + dispatchOnMainThread([this] {
>
> Ditto.
>
> > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:689
> > + dispatchOnMainThread([this, layerID, offset] {
>
> Ditto.</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>