<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Media controls accessibility improvement"
href="https://bugs.webkit.org/show_bug.cgi?id=160223">bug 160223</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #284671 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Media controls accessibility improvement"
href="https://bugs.webkit.org/show_bug.cgi?id=160223#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Media controls accessibility improvement"
href="https://bugs.webkit.org/show_bug.cgi?id=160223">bug 160223</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=284671&action=diff" name="attach_284671" title="patch">attachment 284671</a> <a href="attachment.cgi?id=284671&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=284671&action=review">https://bugs.webkit.org/attachment.cgi?id=284671&action=review</a>
r- for now because of the hard coded timeline step value and the long/flaky test.
<span class="quote">> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:424
> + timeline.step = 1;</span >
While 1 will be a better value than .01 for some movies, it will be much worse for very short files, and it still won't be great for long files. Can you set it to a percentage of the duration in updateDuration instead? You may want to vary the percentage based on duration, e.g. 1% of a 90 second file is almost a second but 1% of a 90 minute is almost a minute, but a I'll bet you can come up with reasonable values with some experimentation.
<span class="quote">> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1727
> + this.controls.currentTime.setAttribute('aria-label', this.UIString('Elapsed') + ' ' + this.formatTime(currentTime));</span >
Nit: A template literal could work well here:
this.controls.currentTime.setAttribute('aria-label', `${this.UIString('Elapsed')} ${this.formatTime(currentTime)}`);
<span class="quote">> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:2104
> + this.controls.volume.setAttribute('aria-valuetext', parseInt(this.controls.volume.value * 100) + '%');</span >
Nit: A template literal could work well here:
this.controls.currentTime.setAttribute('aria-label', `${this.UIString('Remaining')} ${this.formatTime(timeRemaining)}`);
<span class="quote">> LayoutTests/media/audio-controls-timeline-in-media-document.html:21
> + setTimeout("testTimeLineValue()", 1000);</span >
This test now takes a full second, which is a long time for a simple test like this. Additionally, the timeout is likely to make the test flaky. This won't be necessary if you don't always use a 1 second step value.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>