<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Coordinated Graphics] Test fast/fixed-layout/fixed-layout.html crashes in debug"
href="https://bugs.webkit.org/show_bug.cgi?id=160117">bug 160117</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>mcatanzaro@igalia.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Coordinated Graphics] Test fast/fixed-layout/fixed-layout.html crashes in debug"
href="https://bugs.webkit.org/show_bug.cgi?id=160117#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Coordinated Graphics] Test fast/fixed-layout/fixed-layout.html crashes in debug"
href="https://bugs.webkit.org/show_bug.cgi?id=160117">bug 160117</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>And now you have three iOS failures instead of one macOS/iOS failure.
Here is the macOS diff for your original patch. The GraphicsLayer position and bounds just changed to no longer be nice round numbers:
--- /Volumes/Data/EWS/WebKit/WebKitBuild/Debug/layout-test-results/compositing/fixed-with-fixed-layout-expected.txt
+++ /Volumes/Data/EWS/WebKit/WebKitBuild/Debug/layout-test-results/compositing/fixed-with-fixed-layout-actual.txt
@@ -10,7 +10,7 @@
(transform [0.80 0.00 0.00 0.00] [0.00 0.80 0.00 0.00] [0.00 0.00 1.00 0.00] [0.00 0.00 0.00 1.00])
(children 4
(GraphicsLayer
- (bounds 1000.00 100.00)
+ (bounds 982.00 100.00)
(drawsContent 1)
)
(GraphicsLayer
@@ -19,13 +19,13 @@
(drawsContent 1)
)
(GraphicsLayer
- (position 900.00 200.00)
- (bounds 100.00 100.00)
+ (position 881.00 200.00)
+ (bounds 101.00 100.00)
(drawsContent 1)
)
(GraphicsLayer
- (position 0.00 1900.00)
- (bounds 1000.00 100.00)
+ (position 0.00 650.00)
+ (bounds 982.00 100.00)
(drawsContent 1)
)
)
iOS diffs for the new patch:
--- /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/layout-test-results/platform/ios-simulator/ios/fast/coordinates/inner-window-sizes-expected.txt
+++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/layout-test-results/platform/ios-simulator/ios/fast/coordinates/inner-window-sizes-actual.txt
@@ -9,8 +9,8 @@
scaled and panned
PASS window.innerWidth is 400
PASS window.innerHeight is 300
-PASS document.documentElement.clientWidth is 400
-PASS document.documentElement.clientHeight is 300
+FAIL document.documentElement.clientWidth should be 400. Was 800.
+FAIL document.documentElement.clientHeight should be 300. Was 600.
PASS successfullyParsed is true
TEST COMPLETE
--- /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/layout-test-results/platform/ios-simulator/ios/fast/coordinates/inner-window-sizes-quirks-expected.txt
+++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/layout-test-results/platform/ios-simulator/ios/fast/coordinates/inner-window-sizes-quirks-actual.txt
@@ -9,8 +9,8 @@
scaled and panned
PASS window.innerWidth is 400
PASS window.innerHeight is 300
-PASS document.body.clientWidth is 400
-PASS document.body.clientHeight is 300
+FAIL document.body.clientWidth should be 400. Was 800.
+FAIL document.body.clientHeight should be 300. Was 600.
PASS successfullyParsed is true
TEST COMPLETE
--- /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/layout-test-results/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt
+++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/layout-test-results/fast/css/preserve-user-specified-zoom-level-on-reload-actual.txt
@@ -1,8 +1,10 @@
-layer at (0,0) size 2389x1792
- RenderView at (0,0) size 2389x1792
-layer at (0,0) size 2389x1792
- RenderBlock {HTML} at (0,0) size 2389x1792
- RenderBody {BODY} at (23,23) size 2343x1722
- RenderBlock {P} at (0,0) size 2342x57
- RenderText {#text} at (0,1) size 1651x54
- text run at (0,1) width 1651: "This test ensures that we preserve the user-specified zoom level of the page on reload."
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (23,23) size 754x530
+ RenderBlock {P} at (0,0) size 753x171
+ RenderText {#text} at (0,1) size 718x168
+ text run at (0,1) width 718: "This test ensures that we preserve the"
+ text run at (0,58) width 718: "user-specified zoom level of the page"
+ text run at (0,115) width 192: "on reload."</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>