<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Layout test fast/history/page-cache-geolocation-active-oneshot.html is crashing"
href="https://bugs.webkit.org/show_bug.cgi?id=160139#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Layout test fast/history/page-cache-geolocation-active-oneshot.html is crashing"
href="https://bugs.webkit.org/show_bug.cgi?id=160139">bug 160139</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=160139#c2">comment #2</a>)
<span class="quote">> How does it affect page cache? </span >
You added a page cache test in that commit, so seems safe to presume it affects page cache. :)
<span class="quote">> prepareForDestruction() early returns if the
> render tree has already been teared down/things already detached etc, while
> if it hasn't been called yet, we definitely need to do it before the
> document is getting nuked.</span >
I don't imply the change is incorrect (correct changes break tests too). This is a purely speculative blame anyway; some other change could well be to blame, your change just happened to be the last one before the test failed for the first couple of times.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>