<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Fix some video/canvas tests that should be passing"
href="https://bugs.webkit.org/show_bug.cgi?id=160023#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Fix some video/canvas tests that should be passing"
href="https://bugs.webkit.org/show_bug.cgi?id=160023">bug 160023</a>
from <span class="vcard"><a class="email" href="mailto:magomez@igalia.com" title="Miguel Gomez <magomez@igalia.com>"> <span class="fn">Miguel Gomez</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=160023#c9">comment #9</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=284217&action=diff" name="attach_284217" title="Patch">attachment 284217</a> <a href="attachment.cgi?id=284217&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=284217&action=review">https://bugs.webkit.org/attachment.cgi?id=284217&action=review</a>
>
> It likely fails on Mac-WebKit1 because only WebKitTestRunner was updated,
> not DumpRenderTree.</span >
Yeah, my fault. I run the tests in elcapitan but forgot about the platforms that use DRT.
<span class="quote">> > LayoutTests/fast/canvas/canvas-createPattern-video-loading.html:62
> > + tolerance = testRunner.videoCanvasPixelComparisonTolerance;
>
> This is pretty ugly, can't you simply have a GTK-specification version of
> these tests under platform/gtk?</span >
The problem with these tests is that we cannot just create specific expectations for gtk, as the test output includes whether it's failure or success, and also two of them include the tolerance value in the output. We would need to add as expectation an output of the tests that indicates failure, which is weird. So we need to modify the tests somehow to increase that tolerance in the comparison somehow when using GStreamer and Cairo.
But then, from what I've been testing, it's not possible to override a general test with another one placed in platform/gtk (at least I haven't found a way to do so, please correct me if I'm wrong). Maybe adding those tests to the TestExpectations as expected failures and then adding new ones in platform/gtk, but this would mean that we would need to copy every new test that gets added that performs a similar comparison, which is a pain.
I think this approach is a nice solution, having a tolerance value defined for each platform and make the tests to use it. This patch had some problems, but I'll send a new improved version that I think should also work for platforms that use DRT.
As I don't have those platforms to test, I'll the EWS test it for me.
Is that ok for you Chris? Or am I missing something? Comments are very welcome :)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>