<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later"
href="https://bugs.webkit.org/show_bug.cgi?id=159980">bug 159980</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #284260 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later"
href="https://bugs.webkit.org/show_bug.cgi?id=159980#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later"
href="https://bugs.webkit.org/show_bug.cgi?id=159980">bug 159980</a>
from <span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=284260&action=diff" name="attach_284260" title="v2 patch for [iOS] Apps using WKWebView will crash">attachment 284260</a> <a href="attachment.cgi?id=284260&action=edit" title="v2 patch for [iOS] Apps using WKWebView will crash">[details]</a></span>
v2 patch for [iOS] Apps using WKWebView will crash
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=284260&action=review">https://bugs.webkit.org/attachment.cgi?id=284260&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/ios/WKScrollView.mm:47
> + WebKit::WeakObjCPtr<id <UIScrollViewDelegate>> _externalDelegate;</span >
I think you can add “using namespace WebKit” to this file and avoid the WebKit:: qualifier here and elsewhere.
<span class="quote">> Source/WebKit2/UIProcess/ios/WKScrollView.mm:74
> + auto externalDelegate = _externalDelegate.get();
> + return [super respondsToSelector:aSelector] || [_internalDelegate respondsToSelector:aSelector] || [externalDelegate.get() respondsToSelector:aSelector];</span >
Since you’re only using the external delegate once you don’t really have to have this local.
<span class="quote">> Source/WebKit2/UIProcess/ios/WKScrollView.mm:140
> + if (_externalDelegate.get().get() == delegate)</span >
Yikes! I wonder if we should add a == override to WeakObjCPtr.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>