<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later"
href="https://bugs.webkit.org/show_bug.cgi?id=159980#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later"
href="https://bugs.webkit.org/show_bug.cgi?id=159980">bug 159980</a>
from <span class="vcard"><a class="email" href="mailto:cpugh@apple.com" title="Chelsea Pugh <cpugh@apple.com>"> <span class="fn">Chelsea Pugh</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=159980#c6">comment #6</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=284260&action=diff" name="attach_284260" title="v2 patch for [iOS] Apps using WKWebView will crash">attachment 284260</a> <a href="attachment.cgi?id=284260&action=edit" title="v2 patch for [iOS] Apps using WKWebView will crash">[details]</a></span>
> v2 patch for [iOS] Apps using WKWebView will crash
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=284260&action=review">https://bugs.webkit.org/attachment.cgi?id=284260&action=review</a>
>
> > Source/WebKit2/UIProcess/ios/WKScrollView.mm:47
> > + WebKit::WeakObjCPtr<id <UIScrollViewDelegate>> _externalDelegate;
>
> I think you can add “using namespace WebKit” to this file and avoid the
> WebKit:: qualifier here and elsewhere.</span >
Will do
<span class="quote">>
> > Source/WebKit2/UIProcess/ios/WKScrollView.mm:74
> > + auto externalDelegate = _externalDelegate.get();
> > + return [super respondsToSelector:aSelector] || [_internalDelegate respondsToSelector:aSelector] || [externalDelegate.get() respondsToSelector:aSelector];
>
> Since you’re only using the external delegate once you don’t really have to
> have this local.</span >
Okay
<span class="quote">>
> > Source/WebKit2/UIProcess/ios/WKScrollView.mm:140
> > + if (_externalDelegate.get().get() == delegate)
>
> Yikes! I wonder if we should add a == override to WeakObjCPtr.</span >
Maybe, but likely out of scope for this patch</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>