<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GStreamer][GL] crash within triggerRepaint"
href="https://bugs.webkit.org/show_bug.cgi?id=159552#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GStreamer][GL] crash within triggerRepaint"
href="https://bugs.webkit.org/show_bug.cgi?id=159552">bug 159552</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=159552#c7">comment #7</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=283139&action=diff" name="attach_283139" title="patch">attachment 283139</a> <a href="attachment.cgi?id=283139&action=edit" title="patch">[details]</a></span>
> patch
>
> > I understand the concerns about reducing performance but if there isn't we
> > should create a function to do something like:
> >
> > {
> > auto weakThis = player.createWeakPtr();
> > RunLoop::main().runNowIfMainThreadOrdispatch([weakThis]) {
> > if (weakThis)
> > weakThis->m_player->sizeChanged();
> > });
> > }
> >
> > Otherwise I think we are creating these code structures and IMHO it makes
> > code hard to read.
>
> Let's not block landing this because of this nit, but please, open a new bug
> about this.</span >
A nit? This is needed to avoid a crash because of a user after free, I wouldn't say it's a nit.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>