<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:keith_miller@apple.com" title="Keith Miller <keith_miller@apple.com>"> <span class="fn">Keith Miller</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - LLInt should support other types of prototype GetById caching."
href="https://bugs.webkit.org/show_bug.cgi?id=158083">bug 158083</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #282418 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - LLInt should support other types of prototype GetById caching."
href="https://bugs.webkit.org/show_bug.cgi?id=158083#c106">Comment # 106</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - LLInt should support other types of prototype GetById caching."
href="https://bugs.webkit.org/show_bug.cgi?id=158083">bug 158083</a>
from <span class="vcard"><a class="email" href="mailto:keith_miller@apple.com" title="Keith Miller <keith_miller@apple.com>"> <span class="fn">Keith Miller</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=282418&action=diff" name="attach_282418" title="Patch">attachment 282418</a> <a href="attachment.cgi?id=282418&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=282418&action=review">https://bugs.webkit.org/attachment.cgi?id=282418&action=review</a>
<span class="quote">> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:686
> + } else if (UNLIKELY(pc[7].u.operand && (slot.isValue() || slot.isUnset() || ((slot.isAccessor() || slot.isCustom()) && (slot.slotBase() != baseValue))))) {</span >
I think this could just be:
if (UNLIKELY(pc[7].u.operand && (slot.slotBase() != baseValue)))))
<span class="quote">> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1476
> + push t1 # Load arg3 JSObject *
> + push t2 # Load arg2 PropertyName
> + move CellTag, t3
> + if BIG_ENDIAN
> + push t1 # Load arg1 Payload of EncodedJSValue
> + push t3 # Load arg1 Tag of EncodedJSValue
> + else
> + push t3 # Load arg1 Tag of EncodedJSValue
> + push t1 # Load arg1 Payload of EncodedJSValue
> + end
> + push cfr # Loading exec</span >
Looking at this closer. I don't think this is going to work on ARM. The ARM calling convention passes the first four arguments in r0-r3. Additionally, depending on whether or not the device is using the EABI 64-bit values need to start in r0 or r2.
<span class="quote">> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1333
> + loadp Callee[cfr], t0
> + andp MarkedBlockMask, t0, t1
> + loadp MarkedBlock::m_weakSet + WeakSet::m_vm[t1], t1</span >
It is probably worthwhile to make this a macro in LowLevelInterpreter.asm, loadVM(register) or something.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>