<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:benjamin@webkit.org" title="Benjamin Poulain <benjamin@webkit.org>"> <span class="fn">Benjamin Poulain</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - js/dom/global-constructors-attributes.html is flaky: ResourceTiming runtime feature leaks between tests"
href="https://bugs.webkit.org/show_bug.cgi?id=158902">bug 158902</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>benjamin@webkit.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - js/dom/global-constructors-attributes.html is flaky: ResourceTiming runtime feature leaks between tests"
href="https://bugs.webkit.org/show_bug.cgi?id=158902#c40">Comment # 40</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - js/dom/global-constructors-attributes.html is flaky: ResourceTiming runtime feature leaks between tests"
href="https://bugs.webkit.org/show_bug.cgi?id=158902">bug 158902</a>
from <span class="vcard"><a class="email" href="mailto:benjamin@webkit.org" title="Benjamin Poulain <benjamin@webkit.org>"> <span class="fn">Benjamin Poulain</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158902#c34">comment #34</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=158902#c33">comment #33</a>)
> > Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=282941&action=diff" name="attach_282941" title="Patch">attachment 282941</a> <a href="attachment.cgi?id=282941&action=edit" title="Patch">[details]</a></span>
> > Patch
> >
> > View in context:
> > <a href="https://bugs.webkit.org/attachment.cgi?id=282941&action=review">https://bugs.webkit.org/attachment.cgi?id=282941&action=review</a>
> >
> > Check this before landing:
> >
> > > Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:67
> > > - , m_isIndexedDBEnabled(false)
> > > + m_isIndexedDBEnabled = true;
> >
> > You are changing this default. Is is intended?
>
> It is intended, but I'm not 100% sure this is the right thing to do. See
> <a class="bz_bug_link
bz_status_NEW "
title="NEW - js/dom/global-constructors-attributes.html is flaky: ResourceTiming runtime feature leaks between tests"
href="show_bug.cgi?id=158902#c31">https://bugs.webkit.org/show_bug.cgi?id=158902#c31</a>
>
> The default gets overridden to true in the mac and win WebViews as well as
> the WK2 port, and there are various tests that rely on it. But, other ports
> don't necessarily turn it on, so changing the default would change their
> behavior. So, I'm not sure what's the best course of action here</span >
I prefer your previous approach. My previous r+ still holds.
For testing, we should have a common environment for all ports. If Mac and Win already enabled it by default, it sounds like the right thing to do is to enable it everywhere.
IndexedDB is an important feature anyway. It is beneficial for GTK and EFL to support it ASAP.
I would prefer if you land the previous patch with common features and a reset(). If that breaks the universe, we roll back and discuss what to do about GTK/EFL.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>