<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Coordinated Graphics] Modernize and cleanup CompositingCoordinator"
href="https://bugs.webkit.org/show_bug.cgi?id=159212#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Coordinated Graphics] Modernize and cleanup CompositingCoordinator"
href="https://bugs.webkit.org/show_bug.cgi?id=159212">bug 159212</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=159212#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=282417&action=diff" name="attach_282417" title="Rebased patch">attachment 282417</a> <a href="attachment.cgi?id=282417&action=edit" title="Rebased patch">[details]</a></span>
> Rebased patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=282417&action=review">https://bugs.webkit.org/attachment.cgi?id=282417&action=review</a></span >
Thanks for the review.
<span class="quote">> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:217
> > +void CompositingCoordinator::updateImageBacking(CoordinatedImageBackingID imageID, RefPtr<CoordinatedSurface>& coordinatedSurface)
>
> I don't think this should be receiving a reference to RefPtr.</span >
Could you elaborate? what's wrong with the reference and what should I do instead? just copying the RefPtr? I don't understand whey PassRefPtr is used there TBH.
<span class="quote">> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:286
> > +void CompositingCoordinator::createUpdateAtlas(uint32_t atlasID, RefPtr<CoordinatedSurface>& coordinatedSurface)
>
> I don't think this should be receiving a reference to RefPtr.
>
> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:357
> > + if (auto layer = m_registeredLayers.get(layerID))
>
> auto*, since m_registeredLayers is mapping IDs to pointers to
> CoordinatedGraphicsLayer objects.</span >
Isn't that automatic? doesn't auto deduce it's a pointer?
<span class="quote">> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:88
> > - std::unique_ptr<CompositingCoordinator> m_coordinator;
> > + CompositingCoordinator m_coordinator;
>
> You can drop WTF_MAKE_FAST_ALLOCATED from CompositingCoordinator class now.</span >
Indeed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>