<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Too much duplicated code in LayerTreeHosts implementations"
href="https://bugs.webkit.org/show_bug.cgi?id=159144#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Too much duplicated code in LayerTreeHosts implementations"
href="https://bugs.webkit.org/show_bug.cgi?id=159144">bug 159144</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=159144#c8">comment #8</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=282123&action=diff" name="attach_282123" title="Try to fix EFL build">attachment 282123</a> <a href="attachment.cgi?id=282123&action=edit" title="Try to fix EFL build">[details]</a></span>
> Try to fix EFL build
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=282123&action=review">https://bugs.webkit.org/attachment.cgi?id=282123&action=review</a>
>
> >>>> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:65
> >>>> + class CompositorClient final : public ThreadedCompositor::Client {
> >>>
> >>> What about to add WTF_MAKE_NONCOPYABLE to make sure?
> >>
> >> It's private and stack allocated only, LayerTreeHost is already non copyable, so I don't see how it can be copied.
> >
> > It's not stack-allocated, it's allocated on the heap by being located inside the ThreadedCoordinatedLayerTreeHost.
> >
> > It can be copied, ThreadedCompositor::Client is copyable and the LayerTreeHost reference doesn't prevent it either.
>
> r=me with WTF_MAKE_NONCOPYABLE.</span >
Ok, thanks!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>