<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r202337) [WebRTC] Crash when loading html5test.com"
href="https://bugs.webkit.org/show_bug.cgi?id=159145#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r202337) [WebRTC] Crash when loading html5test.com"
href="https://bugs.webkit.org/show_bug.cgi?id=159145">bug 159145</a>
from <span class="vcard"><a class="email" href="mailto:adam.bergkvist@ericsson.com" title="Adam Bergkvist <adam.bergkvist@ericsson.com>"> <span class="fn">Adam Bergkvist</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=159145#c5">comment #5</a>)
Thanks for reviewing, Alex
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=282224&action=diff" name="attach_282224" title="Proposed patch">attachment 282224</a> <a href="attachment.cgi?id=282224&action=edit" title="Proposed patch">[details]</a></span>
> Proposed patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=282224&action=review">https://bugs.webkit.org/attachment.cgi?id=282224&action=review</a>
>
> > Source/WebCore/platform/mediastream/MediaEndpoint.cpp:56
> > +class NullMediaEndpoint : public MediaEndpoint {
>
> I think EmptyMediaEndpoint would be a better name.</span >
EmptyMediaEndpoint and EmptyRealtimeMediaSource works for me.
<span class="quote">> > Source/WebCore/platform/mediastream/MediaEndpoint.cpp:80
> > + return std::unique_ptr<MediaEndpoint>(new NullMediaEndpoint(client));
>
> make_unique. Also, this function is not necessary. Just use
> std::make_unique instead of this.</span >
Are you referring to the createMediaEndpoint() function here? The MediaEndpointPeerConnection constructor calls createMediaEndpoint() to create its MediaEndpoint - in this case an "empty" one. When a port has a "real" MediaEndponit implementation it provides its own createMediaEndpoint() that's called instead.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>