<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Too much duplicated code in LayerTreeHosts implementations"
   href="https://bugs.webkit.org/show_bug.cgi?id=159144#c6">Comment # 6</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Too much duplicated code in LayerTreeHosts implementations"
   href="https://bugs.webkit.org/show_bug.cgi?id=159144">bug 159144</a>
              from <span class="vcard"><a class="email" href="mailto:cgarcia&#64;igalia.com" title="Carlos Garcia Campos &lt;cgarcia&#64;igalia.com&gt;"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
        <pre>(In reply to <a href="show_bug.cgi?id=159144#c5">comment #5</a>)
<span class="quote">&gt; Comment on <span class=""><a href="attachment.cgi?id=282123&amp;action=diff" name="attach_282123" title="Try to fix EFL build">attachment 282123</a> <a href="attachment.cgi?id=282123&amp;action=edit" title="Try to fix EFL build">[details]</a></span>
&gt; Try to fix EFL build
&gt; 
&gt; View in context:
&gt; <a href="https://bugs.webkit.org/attachment.cgi?id=282123&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=282123&amp;action=review</a>
&gt; 
&gt; &gt; Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:207
&gt; &gt; +    UNUSED_PARAM(size);
&gt; 
&gt; Maybe using ASSERT_NOT_REACHED would be nice to use here.</span >

Sure.

<span class="quote">&gt; &gt; Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:65
&gt; &gt; +    class CompositorClient final : public ThreadedCompositor::Client {
&gt; 
&gt; What about to add WTF_MAKE_NONCOPYABLE to make sure?</span >

It's private and stack allocated only, LayerTreeHost is already non copyable, so I don't see how it can be copied.

<span class="quote">&gt; &gt; Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h:73
&gt; &gt;      virtual void sizeDidChange(const WebCore::IntSize&amp; newSize) = 0;
&gt; 
&gt; What about change the name of it to the viewportSizeChanged, as we discussed
&gt; earlier?</span >

That doesn't belong to this patch, this is about sharing existing code, I avoided changes like that to make sure I don't break EFL port.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>