<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][EFL] Build with threaded compositor enabled is broken"
href="https://bugs.webkit.org/show_bug.cgi?id=159138#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][EFL] Build with threaded compositor enabled is broken"
href="https://bugs.webkit.org/show_bug.cgi?id=159138">bug 159138</a>
from <span class="vcard"><a class="email" href="mailto:magomez@igalia.com" title="Miguel Gomez <magomez@igalia.com>"> <span class="fn">Miguel Gomez</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=159138#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=282115&action=diff" name="attach_282115" title="Patch">attachment 282115</a> <a href="attachment.cgi?id=282115&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=282115&action=review">https://bugs.webkit.org/attachment.cgi?id=282115&action=review</a>
>
> > Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:-124
> > - cairoSurfaceSetDeviceScale(m_compositorSurface.get(), m_resolutionScale, m_resolutionScale);
>
> Are you sure we don't need this here? Shouldn't we pass the resolution scale
> to the data structure instead?</span >
Sure, we don't need it. The compositor buffer is only used to copy the canvas content and take it to the composition stage when the accelerated canvas is enabled. And according to the comments in r202421, the HiDPI canvas feature was removed, so when using a canvas the resolution factor is always 1.
But we can store the resolutionScale in the data structure as well, yes. If you prefer that approach I can update the patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>