<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Add support for the negotiationneeded event in MediaEndpointPeerConnection"
href="https://bugs.webkit.org/show_bug.cgi?id=158985#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Add support for the negotiationneeded event in MediaEndpointPeerConnection"
href="https://bugs.webkit.org/show_bug.cgi?id=158985">bug 158985</a>
from <span class="vcard"><a class="email" href="mailto:adam.bergkvist@ericsson.com" title="Adam Bergkvist <adam.bergkvist@ericsson.com>"> <span class="fn">Adam Bergkvist</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158985#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=281737&action=diff" name="attach_281737" title="Proposed patch">attachment 281737</a> <a href="attachment.cgi?id=281737&action=edit" title="Proposed patch">[details]</a></span>
> Proposed patch</span >
Thanks for reviewing
<span class="quote">> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=281737&action=review">https://bugs.webkit.org/attachment.cgi?id=281737&action=review</a>
>
> > LayoutTests/ChangeLog:15
> > + * fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt: Added.
> > + * fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html: Added.
> > + Verify that a negotiationneeded event is fired when not all local media can be included in
> > + an answer. (The answerer cannot reply with more m-lines than the offer had to begin with.)
> > + * fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
> > + * fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
>
> Don't we also need a test for a stream track entering an ended state? A bug
> for adding that test is fine if you don't want to do it in this patch.</span >
We should also test that case. I remember that we've talked about an internal test API to emulate events originating from the browser; something like "stopSourceOfTrack(track)". That would be useful here. About a bug, see next comment.
<span class="quote">> Are there any other operations that should generate a 'negotiationneeded'
> event?</span >
There's an issue [1] filed on the WebRTC 1.0 github repo about putting together a table will all cases that must set the 'negotiation needed flag'. I've also referenced this issue in a new bug about adding more tests [2].
[1] <a href="https://github.com/w3c/webrtc-pc/issues/661">https://github.com/w3c/webrtc-pc/issues/661</a>
[2] <a href="http://webkit.org/b/159016">http://webkit.org/b/159016</a>
<span class="quote">> > LayoutTests/fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html:10
> > + description("Test that a negotiationneeded event is fired when all local media can't be included in an answer");
>
> Nit: "when all local media can't be included" -> "when not all local media
> can be included"</span >
Will fix.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>