<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Replace RTCPeerConnection custom constructor with a JS built-in constructor"
href="https://bugs.webkit.org/show_bug.cgi?id=158832#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Replace RTCPeerConnection custom constructor with a JS built-in constructor"
href="https://bugs.webkit.org/show_bug.cgi?id=158832">bug 158832</a>
from <span class="vcard"><a class="email" href="mailto:adam.bergkvist@ericsson.com" title="Adam Bergkvist <adam.bergkvist@ericsson.com>"> <span class="fn">Adam Bergkvist</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158832#c6">comment #6</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=281665&action=diff" name="attach_281665" title="Updated patch">attachment 281665</a> <a href="attachment.cgi?id=281665&action=edit" title="Updated patch">[details]</a></span>
> Updated patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=281665&action=review">https://bugs.webkit.org/attachment.cgi?id=281665&action=review</a>
>
> > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:83
> > + Document& document = downcast<Document>(*scriptExecutionContext());
>
> It might be better to use CallWith=Document in the IDL to pass Document as
> parameter to the IDL</span >
Fixed.
<span class="quote">> > Source/WebCore/Modules/mediastream/RTCPeerConnection.h:66
> > + void initializeWith(const Dictionary& rtcConfiguration, ExceptionCode&);
>
> Is "rtcConfiguration" needed?</span >
It contains all the settings passed to the constructor.
<span class="quote">> > Source/WebCore/Modules/mediastream/RTCPeerConnection.js:44
> > + this.@initializeWith(configuration);
>
> I am not quite sure but can we find a better handling of errors than
> catching-and-rethrowing?
> Would it be more readable to make initializeWith return a status code
> instead?</span >
I agree that catching and re-throwing is not ideal and that we should aim for something nicer. My plan is to revamp the RTCPeerConnection constructor, and probably the related setConfiguration() method, entirely in [1] to make them spec compliant. We probably want to define the RTCConfiguration dictionary (argument to constructor and setConfiguration()) properly in IDL or do something in the JS built-ins to get nice error messages. So further tweaks to this code will most likely be throw away soon. Is it OK going forward with that plan and commit this to unlock the blocked bugs?
[1] <a href="http://webkit.org/b/158936">http://webkit.org/b/158936</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>