<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: RTCIceCandidate init dictionary don't handle explicit null or undefined values correctly"
href="https://bugs.webkit.org/show_bug.cgi?id=158873#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: RTCIceCandidate init dictionary don't handle explicit null or undefined values correctly"
href="https://bugs.webkit.org/show_bug.cgi?id=158873">bug 158873</a>
from <span class="vcard"><a class="email" href="mailto:adam.bergkvist@ericsson.com" title="Adam Bergkvist <adam.bergkvist@ericsson.com>"> <span class="fn">Adam Bergkvist</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158873#c2">comment #2</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=281562&action=diff" name="attach_281562" title="Proposed patch">attachment 281562</a> <a href="attachment.cgi?id=281562&action=edit" title="Proposed patch">[details]</a></span>
> Proposed patch</span >
Thanks for the reviews
<span class="quote">> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=281562&action=review">https://bugs.webkit.org/attachment.cgi?id=281562&action=review</a>
>
> > Source/WebCore/ChangeLog:8
> > + Prevent explicit null and undefined values to be converted to "null" and "undefined" strings.
>
> Nit: "values to be converted to" -> "values from being converted to"</span >
Fixed.
(In reply to <a href="show_bug.cgi?id=158873#c3">comment #3</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=281562&action=diff" name="attach_281562" title="Proposed patch">attachment 281562</a> <a href="attachment.cgi?id=281562&action=edit" title="Proposed patch">[details]</a></span>
> Proposed patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=281562&action=review">https://bugs.webkit.org/attachment.cgi?id=281562&action=review</a>
>
> > Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp:59
> > + if (dictionary.getWithUndefinedOrNullCheck("sdpMLineIndex", sdpMLineIndexString)) {
> > + if (!sdpMLineIndexString.isNull()) {
>
> I think you can join the 2 ifs in just one with an and condition. Also check
> if getWithUndefinedOrNullCheck returns false if undefined or null, maybe we
> do not need the second condition.</span >
Dug a bit deeper and getWithUndefinedOrNullCheck() returns false if the dictionary member was undefined or false; rendering the second check is unnecessary. Fixed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>