<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Moved key function of JSC::StringSourceProvider to JSC library."
href="https://bugs.webkit.org/show_bug.cgi?id=158798#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Moved key function of JSC::StringSourceProvider to JSC library."
href="https://bugs.webkit.org/show_bug.cgi?id=158798">bug 158798</a>
from <span class="vcard"><a class="email" href="mailto:mark.lam@apple.com" title="Mark Lam <mark.lam@apple.com>"> <span class="fn">Mark Lam</span></a>
</span></b>
<pre>The bots are complaining about:
Undefined symbols for architecture i386:
"vtable for JSC::StringSourceProvider", referenced from:
I think your patch is incorrect. What you want is to move the StringSourceProvider constructor to the cpp file, and make that JS_EXPORT_PRIVATE. Then, you won't need to export the vtable. You also don't need to override the destructor.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>