<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - LLInt should support other types of prototype GetById caching."
href="https://bugs.webkit.org/show_bug.cgi?id=158083#c49">Comment # 49</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - LLInt should support other types of prototype GetById caching."
href="https://bugs.webkit.org/show_bug.cgi?id=158083">bug 158083</a>
from <span class="vcard"><a class="email" href="mailto:keith_miller@apple.com" title="Keith Miller <keith_miller@apple.com>"> <span class="fn">Keith Miller</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158083#c47">comment #47</a>)
<span class="quote">> But I should have suggested something simpler yesterday.
> When you convert your get_by_id into your specialized version, you
> can stash the UniquedStringImpl* into the instruction stream itself if
> you have an unused instruction offset. Do you have such a free location?</span >
This is a good idea. We have an invariant that changing a Accessor on an object requires transitioning the structure of that object. This means that you can use, for example, pc[4] to hold the function pointer and pc[5] to point to the UniquedStringImpl* of the property.
(In reply to <a href="show_bug.cgi?id=158083#c46">comment #46</a>)
<span class="quote">> I would like to know if there is a way to test the changes in all
> architectures.</span >
It can be pretty tricky. I would recommend having the bot do it since, IIRC, we test all the architectures we care about.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>