<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - LLInt should support other types of prototype GetById caching."
href="https://bugs.webkit.org/show_bug.cgi?id=158083#c51">Comment # 51</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - LLInt should support other types of prototype GetById caching."
href="https://bugs.webkit.org/show_bug.cgi?id=158083">bug 158083</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158083#c49">comment #49</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=158083#c47">comment #47</a>)
> > But I should have suggested something simpler yesterday.
> > When you convert your get_by_id into your specialized version, you
> > can stash the UniquedStringImpl* into the instruction stream itself if
> > you have an unused instruction offset. Do you have such a free location?
>
> This is a good idea. We have an invariant that changing a Accessor on an
> object requires transitioning the structure of that object. This means that
> you can use, for example, pc[4] to hold the function pointer and pc[5] to
> point to the UniquedStringImpl* of the property.
>
> (In reply to <a href="show_bug.cgi?id=158083#c46">comment #46</a>)
> > I would like to know if there is a way to test the changes in all
> > architectures.
>
> It can be pretty tricky. I would recommend having the bot do it since, IIRC,
> we test all the architectures we care about.</span >
Yeah it is indeed tricky. We do have some ARM EWS bots so if you upload relevant
tests in a LayoutTest, EWS will run it for you. Unfortunately, we don't have
run-javascriptcore-tests on EWS, but we have internal bots that will alert us of
failure at Apple.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>