<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Form label text should be exposed as static text if it contains only static text"
href="https://bugs.webkit.org/show_bug.cgi?id=158634#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Form label text should be exposed as static text if it contains only static text"
href="https://bugs.webkit.org/show_bug.cgi?id=158634">bug 158634</a>
from <span class="vcard"><a class="email" href="mailto:d_russell@apple.com" title="Doug Russell <d_russell@apple.com>"> <span class="fn">Doug Russell</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=281045&action=diff" name="attach_281045" title="Patch">attachment 281045</a> <a href="attachment.cgi?id=281045&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=281045&action=review">https://bugs.webkit.org/attachment.cgi?id=281045&action=review</a>
<span class="quote">>> Source/WebCore/accessibility/AccessibilityLabel.cpp:76
>> + staticText = true;
>
> Seems like you don't need to keep track of staticText. As soon as you get a failure can you can just return false
>
> Then you can return true at the end of it right
>
> Also, you could probably cache this value and then update when children are updated</span >
Having bool staticText means I don't have to check if children is empty. I could switch to size == 0 at the top.
Caching seemed tricky given there seem to be a lot of cases where the funnels aren't used and m_children.append() is used directly. And this method needs to be const to be called from stringValue() so calculating lazily and caching is tricky.
<span class="quote">>> Source/WebCore/accessibility/AccessibilityLabel.cpp:92
>> + return WebCore::containsOnlyStaticText(m_children);
>
> This WebCore:: prefix is probably unnecessary</span >
You need it to disambiguate from AccessibilityLabel::containsOnlyStaticText() (the compiler gets huffy without it)
<span class="quote">>> Source/WebCore/accessibility/AccessibilityLabel.h:41
>> + AccessibilityRole roleValue() const override { return LabelRole; }
>
> Add a final to these
>
> roleValue and stringValue() can probably be private</span >
Will do on final.
I'll see about role and string.
<span class="quote">>> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2237
>> + if (role == LabelRole && is<AccessibilityLabel>(*m_object) && downcast<AccessibilityLabel>(*m_object).containsOnlyStaticText())
>
> This check
> role == LabelRole
>
> Is probably not necessary since is<AccessibilityLabel> guarantees role = Label</span >
It's not strictly necessary, but it seemed likely that role == Label was cheaper than calling is<> on every m_object.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>