<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Imlement MediaEndpointPeerConnection::setRemoteDescription()"
href="https://bugs.webkit.org/show_bug.cgi?id=158467#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: Imlement MediaEndpointPeerConnection::setRemoteDescription()"
href="https://bugs.webkit.org/show_bug.cgi?id=158467">bug 158467</a>
from <span class="vcard"><a class="email" href="mailto:adam.bergkvist@ericsson.com" title="Adam Bergkvist <adam.bergkvist@ericsson.com>"> <span class="fn">Adam Bergkvist</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158467#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=280807&action=diff" name="attach_280807" title="Proposed patch">attachment 280807</a> <a href="attachment.cgi?id=280807&action=edit" title="Proposed patch">[details]</a></span>
> Proposed patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=280807&action=review">https://bugs.webkit.org/attachment.cgi?id=280807&action=review</a>
>
> > LayoutTests/fast/mediastream/RTCTrackEvent-constructor.html:64
> > + debug("Dictionary members receiver, track and transceiver are not nullable");
> > + shouldThrow("new RTCTrackEvent('eventType', { receiver: null, track: track, transceiver: transceiver})");
> > + shouldThrow("new RTCTrackEvent('eventType', { receiver: receiver, track: null, transceiver: transceiver})");
> > + shouldThrow("new RTCTrackEvent('eventType', { receiver: receiver, track: track, transceiver: null})");
> > + debug("");
> > +
> > + debug("Dictionary members receiver, track and transceiver are required");
> > + shouldThrow("new RTCTrackEvent('eventType', { track: track, transceiver: transceiver})");
> > + shouldThrow("new RTCTrackEvent('eventType', { receiver: receiver, transceiver: transceiver})");
> > + shouldThrow("new RTCTrackEvent('eventType', { receiver: receiver, track: track})");
> > + debug("");
>
> Please add a FIXME and a bug # about these failures.</span >
Fixed.
Bug: <a class="bz_bug_link
bz_status_NEW "
title="NEW - Bindings: [InitializedByEventConstructor] should support required and non-nullable dictionary members"
href="show_bug.cgi?id=158536">https://bugs.webkit.org/show_bug.cgi?id=158536</a>
<span class="quote">> > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:389
> > +
>
> Minor nit: I find the blank line here slightly distracting</span >
Gone. :)
<span class="quote">> > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:401
> > +
> > +
>
> Ditto.</span >
Fixed.
<span class="quote">> > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:412
> > + for (unsigned i = 0; i < mediaDescriptions.size(); ++i) {
> > + PeerMediaDescription* mediaDescription = mediaDescriptions[i].get();
>
> Nit: can you use a modern for loop here?</span >
True. Fixed.
<span class="quote">> > Source/WebCore/Modules/mediastream/RTCTrackEvent.idl:37
> > + [InitializedByEventConstructor] readonly attribute MediaStream[] streams;
>
> Can you use "attribute sequence<MediaStream> streams" instead?</span >
A sequence can't be an interface attribute [1].
[1] <a href="http://heycam.github.io/webidl/#idl-sequence">http://heycam.github.io/webidl/#idl-sequence</a>
<span class="quote">> > Source/WebCore/platform/mock/MockMediaEndpoint.cpp:140
> > + for (auto& p : defaultPayloads) {
>
> Nit: a single letter variable name in a modern for loop - such an
> anachronism :-)
>
> Might as well spell out the variable.</span >
Ops. :) Let's use payload since defaultPayload is taken.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>