<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: WKWebView should have API to prevent pinch-to-zoom always being allowed"
href="https://bugs.webkit.org/show_bug.cgi?id=158364#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: WKWebView should have API to prevent pinch-to-zoom always being allowed"
href="https://bugs.webkit.org/show_bug.cgi?id=158364">bug 158364</a>
from <span class="vcard"><a class="email" href="mailto:n_wang@apple.com" title="Nan Wang <n_wang@apple.com>"> <span class="fn">Nan Wang</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158364#c10">comment #10</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=158364#c9">comment #9</a>)
> > (In reply to <a href="show_bug.cgi?id=158364#c8">comment #8</a>)
> > > Comment on <span class=""><a href="attachment.cgi?id=280478&action=diff" name="attach_280478" title="patch">attachment 280478</a> <a href="attachment.cgi?id=280478&action=edit" title="patch">[details]</a></span>
> > > patch
> > >
> > > View in context:
> > > <a href="https://bugs.webkit.org/attachment.cgi?id=280478&action=review">https://bugs.webkit.org/attachment.cgi?id=280478&action=review</a>
> > >
> > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h:248
> > > > +@property (nonatomic) BOOL alwaysUserScalable WK_AVAILABLE(NA, 10_0);
> > >
> > > The naming of this API is surprising (and the fact that it's API at all, to
> > > start out with). I cc'd andersca for thoughts.
> > >
> > > >>>> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2214
> > > >>>> +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000
> > > >>>
> > > >>> Is all the iOS versioning required? This code will never run on an older device right
> > > >>
> > > >> Because we set the property WK_AVAILABLE(NA, 10_0), do you think we should remove that as well?
> >
> > New APIs should be versioned. We use WK_IOS_TBA for new APIs. I don't like
> > the name.</span >
Do you have any suggestion for the name?
<span class="quote">>
> The interface should have availability macros, yes, but the implementation
> shouldn't be #if'd out, should it?</span >
I think the code won't compile if the version is lower than the availability macro.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>