<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:beidson@apple.com" title="Brady Eidson <beidson@apple.com>"> <span class="fn">Brady Eidson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED WONTFIX - Do everything necessary to make IDBConnectionToServer::putOrAdd pass it's key by rvalue"
href="https://bugs.webkit.org/show_bug.cgi?id=158391">bug 158391</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>WONTFIX
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED WONTFIX - Do everything necessary to make IDBConnectionToServer::putOrAdd pass it's key by rvalue"
href="https://bugs.webkit.org/show_bug.cgi?id=158391#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED WONTFIX - Do everything necessary to make IDBConnectionToServer::putOrAdd pass it's key by rvalue"
href="https://bugs.webkit.org/show_bug.cgi?id=158391">bug 158391</a>
from <span class="vcard"><a class="email" href="mailto:beidson@apple.com" title="Brady Eidson <beidson@apple.com>"> <span class="fn">Brady Eidson</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158391#c0">comment #0</a>)
<span class="quote">> Do everything necessary to make IDBConnectionToServer::putOrAdd pass it's
> key by rvalue
>
> This is a spinoff from <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED"
href="show_bug.cgi?id=158124">https://bugs.webkit.org/show_bug.cgi?id=158124</a>
>
> It seems simple to do this, but it opens a can of worms making templated
> objects and lambdas handle it.
>
> But we should still do it.</span >
Actually... this is unlikely to be possible: The can of worms that opens is once that IDBKeyData rvalue hits CrossThreadCopier/CrossThreadTask.
But when an object hits those, we *have* to make an isolatedCopy.
So whether we WTFMove the IDBKeyData&& all the way along the chain, or just pass it by const IDBKeyData& all the way along the chain, we get no benefit - We have to make an isolatedCopy in the end.
That said, while exploring this I came up with some great enhancements to CrossThreadTask.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>