<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [ESNext] Support trailing commas in function param lists"
href="https://bugs.webkit.org/show_bug.cgi?id=158020#c22">Comment # 22</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [ESNext] Support trailing commas in function param lists"
href="https://bugs.webkit.org/show_bug.cgi?id=158020">bug 158020</a>
from <span class="vcard"><a class="email" href="mailto:gskachkov@gmail.com" title="GSkachkov <gskachkov@gmail.com>"> <span class="fn">GSkachkov</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158020#c21">comment #21</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=280527&action=diff" name="attach_280527" title="Patch">attachment 280527</a> <a href="attachment.cgi?id=280527&action=edit" title="Patch">[details]</a></span>
> Patch
>
> Let's try landing it. Can you also run sunspider locally to see if you see
> any perf regressions?</span >
See results:
VMs tested:
"withoutfix" at /Users/Developer/Projects/Webkit2/WebKitBuild/trailing_comma_perf/Release/jsc
"withfix" at /Users/Developer/Projects/Webkit2/WebKitBuild/trailing_comma/Release/jsc
Collected 4 samples per benchmark/VM, with 4 VM invocations per benchmark. Ran 8 benchmark iterations, and
measured the total time of those iterations, for each sample. Emitted a call to gc() between sample
measurements. Used 32 benchmark iterations per VM invocation for warm-up. Used the jsc-specific
preciseTime() function to get microsecond-level timing. Reporting benchmark execution times with 95%
confidence intervals in milliseconds.
withoutfix withfix
3d-cube 83.8227+-24.3184 76.9651+-3.2111 might be 1.0891x faster
3d-morph 67.9703+-6.1130 ? 69.4963+-4.5539 ? might be 1.0225x slower
3d-raytrace 78.9442+-4.0375 ? 81.5590+-4.3219 ? might be 1.0331x slower
access-binary-trees 38.6298+-1.6829 ? 39.4618+-3.5157 ? might be 1.0215x slower
access-fannkuch 117.1779+-12.1635 ? 117.5690+-4.4082 ?
access-nbody 40.1360+-22.6709 32.2021+-0.6917 might be 1.2464x faster
access-nsieve 36.1190+-3.4944 35.7054+-2.2991 might be 1.0116x faster
bitops-3bit-bits-in-byte 14.3125+-0.6476 ? 14.4402+-1.7659 ?
bitops-bits-in-byte 38.8101+-2.2190 38.4263+-5.0924
bitops-bitwise-and 22.1407+-2.9088 21.9016+-2.3408 might be 1.0109x faster
bitops-nsieve-bits 51.7688+-3.1459 50.5560+-3.9563 might be 1.0240x faster
controlflow-recursive 56.6677+-16.0759 52.8937+-3.5335 might be 1.0714x faster
crypto-aes 57.3966+-6.6903 ? 75.6738+-37.2029 ? might be 1.3184x slower
crypto-md5 37.9637+-3.9742 ? 38.3545+-2.0614 ? might be 1.0103x slower
crypto-sha1 37.6180+-1.6728 37.4700+-3.6662
date-format-tofte 107.7530+-9.8035 103.5540+-7.2543 might be 1.0405x faster
date-format-xparb 119.6010+-4.8767 110.3923+-20.2829 might be 1.0834x faster
math-cordic 38.0562+-2.3593 ? 45.7181+-31.6069 ? might be 1.2013x slower
math-partial-sums 61.3655+-10.2370 58.5570+-5.7249 might be 1.0480x faster
math-spectral-norm 26.5539+-0.4367 ? 27.1837+-0.9924 ? might be 1.0237x slower
regexp-dna 72.3824+-0.6244 ? 74.6293+-4.1073 ? might be 1.0310x slower
string-base64 61.9043+-9.7523 ? 64.7947+-12.5870 ? might be 1.0467x slower
string-fasta 84.9805+-7.7918 ? 85.1760+-5.2455 ?
string-tagcloud 114.4025+-15.2375 108.3253+-8.7008 might be 1.0561x faster
string-unpack-code 220.5273+-18.0041 ? 223.9689+-8.9968 ? might be 1.0156x slower
string-validate-input 72.3325+-33.0462 55.1055+-1.3751 might be 1.3126x faster
<arithmetic> 67.6668+-1.1993 66.9261+-2.3691 might be 1.0111x faster</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>