<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Our parser doesn't properly parse default parameter expressions in a class method"
href="https://bugs.webkit.org/show_bug.cgi?id=157872">bug 157872</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #280072 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Our parser doesn't properly parse default parameter expressions in a class method"
href="https://bugs.webkit.org/show_bug.cgi?id=157872#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Our parser doesn't properly parse default parameter expressions in a class method"
href="https://bugs.webkit.org/show_bug.cgi?id=157872">bug 157872</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=280072&action=diff" name="attach_280072" title="Patch">attachment 280072</a> <a href="attachment.cgi?id=280072&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=280072&action=review">https://bugs.webkit.org/attachment.cgi?id=280072&action=review</a>
Looks good to me, but this patch needs tests before we can land it
I'd add parser tests. We have a file that is for these tests:
LayoutTests/js/parser-syntax-... (I forget the actual file name)
Also, please add some stress tests. I believe I added a fixme in a test
with this bug number. I think if you grep for this bug number you will
find it.
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:2074
> + functionScope->setExpectedSuperBinding(expectedSuperBinding);</span >
Can't this just be moved up to when we create the function scope?
Then the other place where we set this below can be deleted</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>