<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147#c94">Comment # 94</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147">bug 156147</a>
from <span class="vcard"><a class="email" href="mailto:caitp@igalia.com" title="Caitlin Potter (:caitp) <caitp@igalia.com>"> <span class="fn">Caitlin Potter (:caitp)</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=156147#c92">comment #92</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=156147#c90">comment #90</a>)
> > (In reply to <a href="show_bug.cgi?id=156147#c87">comment #87</a>)
> > > Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=279829&action=diff" name="attach_279829" title="Patch">attachment 279829</a> <a href="attachment.cgi?id=279829&action=edit" title="Patch">[details]</a></span>
> > > Patch
> > >
> > > View in context:
> > > <a href="https://bugs.webkit.org/attachment.cgi?id=279829&action=review">https://bugs.webkit.org/attachment.cgi?id=279829&action=review</a>
> > >
> > > Looks good to me.
> > > Before landing, please ensure that JSBench (you can run it with
> > > run-jsc-benchmark) does not has regression,
> > > since JSBench is good for measuring the code loading (parser) performance.
> > The Parser isn't actually very hot in JSBench because we have
> > the code cache. Octane/code-load (jQuery + closure) are much better
> > indicators of parser performance. Let's run those.
>
> I usually run this for code-load
> `run-jsc-benchmarks --outer 10 --octane --benchmark "closure|jquery"
> baseline:<pathToVMBaseline> changes:<pathToVMWithChanges>`</span >
well, the results of a mix between <a href="show_bug.cgi?id=156147#c91">comment 91</a> and <a href="show_bug.cgi?id=156147#c92">comment 92</a> are this:
Benchmark report for Octane on EchoBeach (MacBookPro11,5).
VMs tested:
"TipOfTree" at /Users/caitp/git/WebKit2/WebKitBuild/Release/DumpRenderTree
"AsyncAwait" at /Users/caitp/git/WebKit/WebKitBuild/Release/DumpRenderTree
Collected 500 samples per benchmark/VM, with 50 VM invocations per benchmark. Emitted a call to
gc() between sample measurements. Used 1 benchmark iteration per VM invocation for warm-up. Used
the jsc-specific preciseTime() function to get microsecond-level timing. Reporting benchmark
execution times with 95% confidence intervals in milliseconds.
TipOfTree AsyncAwait
closure 0.30106+-0.00079 ! 0.30431+-0.00081 ! definitely 1.0108x slower
jquery 2.23843+-0.05744 ? 2.26908+-0.05960 ? might be 1.0137x slower
<geometric> 0.81418+-0.01038 ? 0.82405+-0.01094 ? might be 1.0121x slower
---
Which still isn't great, I guess? It probably gets worse once the runtime flag is removed, too. I'll talk to a colleague about profiling this to see if I can fix it a bit tomorrow/next week.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>