<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147#c92">Comment # 92</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147">bug 156147</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=156147#c90">comment #90</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=156147#c87">comment #87</a>)
> > Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=279829&action=diff" name="attach_279829" title="Patch">attachment 279829</a> <a href="attachment.cgi?id=279829&action=edit" title="Patch">[details]</a></span>
> > Patch
> >
> > View in context:
> > <a href="https://bugs.webkit.org/attachment.cgi?id=279829&action=review">https://bugs.webkit.org/attachment.cgi?id=279829&action=review</a>
> >
> > Looks good to me.
> > Before landing, please ensure that JSBench (you can run it with
> > run-jsc-benchmark) does not has regression,
> > since JSBench is good for measuring the code loading (parser) performance.
> The Parser isn't actually very hot in JSBench because we have
> the code cache. Octane/code-load (jQuery + closure) are much better
> indicators of parser performance. Let's run those.</span >
I usually run this for code-load
`run-jsc-benchmarks --outer 10 --octane --benchmark "closure|jquery" baseline:<pathToVMBaseline> changes:<pathToVMWithChanges>`</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>