<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] Allow clients to override the type of an input field"
href="https://bugs.webkit.org/show_bug.cgi?id=157995">bug 157995</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #279594 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] Allow clients to override the type of an input field"
href="https://bugs.webkit.org/show_bug.cgi?id=157995#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] Allow clients to override the type of an input field"
href="https://bugs.webkit.org/show_bug.cgi?id=157995">bug 157995</a>
from <span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=279594&action=diff" name="attach_279594" title="Fix ChangeLog spacing">attachment 279594</a> <a href="attachment.cgi?id=279594&action=edit" title="Fix ChangeLog spacing">[details]</a></span>
Fix ChangeLog spacing
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=279594&action=review">https://bugs.webkit.org/attachment.cgi?id=279594&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/_WKFormInputSession.h:46
> +@property (nonatomic, strong) NSString *textContentType WK_AVAILABLE(NA, WK_IOS_TBA);</span >
This should be copy, not strong…
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:362
> + if (textContentType == _textContentType)</span >
…so this should check for equality in addition to checking for identity…
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:365
> + _textContentType = textContentType;</span >
…and this should make a copy and adopt it.
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3021
> + if (NSString *textContentType = [_formInputSession textContentType])
> + [_traits setTextContentType:textContentType];
> + else if (NSString *textContentType = contentTypeFromFieldName(_assistedNodeInformation.autofillFieldName))
> + [_traits setTextContentType:textContentType];</span >
The problem with this implementation is that if the field’s autofillFieldName is, say, None, and the client uses the SPI to set textContentType to some non-nil value and then back to nil, the traits’ textContentType doesn’t revert to whatever the default value is for None. Is there a way to avoid this issue?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>