<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - JSC: DFG::SpeculativeJIT::compile special case for MIPS for PutByValWithThis"
href="https://bugs.webkit.org/show_bug.cgi?id=157741#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - JSC: DFG::SpeculativeJIT::compile special case for MIPS for PutByValWithThis"
href="https://bugs.webkit.org/show_bug.cgi?id=157741">bug 157741</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=279023&action=diff" name="attach_279023" title="Patch">attachment 279023</a> <a href="attachment.cgi?id=279023&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=279023&action=review">https://bugs.webkit.org/attachment.cgi?id=279023&action=review</a>
<span class="quote">>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:2933
>> + {
>
> If we won't find a way to avoid excessive moves, I propose to merge this code with X86 code path. Only top 4 lines are different for MIPS, everything else looks like an exact copy of X86</span >
IMO, this will make the code harder to read.
<span class="quote">> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:2947
> + m_jit.move(basePayload, GPRInfo::argumentGPR2);
> + m_jit.move(baseTag, GPRInfo::argumentGPR3);</span >
This is wrong if basePayload/baseTag are aliased to argument registers w/ each other.
i.e, if basePayload is argumentGPR3 and baseTag is argumentGPR2, this code will do the wrong thing.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>