<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:svijayaraghavan@apple.com" title="Sri Vijayaraghavan <svijayaraghavan@apple.com>"> <span class="fn">Sri Vijayaraghavan</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add machine-readable results for JSC API tests to the Buildbot log"
href="https://bugs.webkit.org/show_bug.cgi?id=157642">bug 157642</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #278772 Flags</td>
<td>
</td>
<td>commit-queue?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add machine-readable results for JSC API tests to the Buildbot log"
href="https://bugs.webkit.org/show_bug.cgi?id=157642#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add machine-readable results for JSC API tests to the Buildbot log"
href="https://bugs.webkit.org/show_bug.cgi?id=157642">bug 157642</a>
from <span class="vcard"><a class="email" href="mailto:svijayaraghavan@apple.com" title="Sri Vijayaraghavan <svijayaraghavan@apple.com>"> <span class="fn">Sri Vijayaraghavan</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=278772&action=diff" name="attach_278772" title="Patch">attachment 278772</a> <a href="attachment.cgi?id=278772&action=edit" title="Patch">[details]</a></span>
Patch
I abstracted out the function that writes JSON to the file. This minimizes the number of conditionals (i.e. checking whether --json-output is specified, which is indicated by $jsonFileName being defined) and also reduces the amount of refactoring. Open to suggestions on how to do this better.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>