<html>

    <head>

      <base href="https://bugs.webkit.org/" />

    </head>

    <body><table border="1" cellspacing="0" cellpadding="8">

        <tr>

          <th>Bug ID</th>

          <td><a class="bz_bug_link 

          bz_status_NEW "

   title="NEW - Protector Ref/RefPtrs should have a specified naming style"

   href="https://bugs.webkit.org/show_bug.cgi?id=157591">157591</a>

          </td>

        </tr>

        <tr>

          <th>Summary</th>

          <td>Protector Ref/RefPtrs should have a specified naming style

          </td>

        </tr>

        <tr>

          <th>Classification</th>

          <td>Unclassified

          </td>

        </tr>

        <tr>

          <th>Product</th>

          <td>WebKit

          </td>

        </tr>

        <tr>

          <th>Version</th>

          <td>WebKit Nightly Build

          </td>

        </tr>

        <tr>

          <th>Hardware</th>

          <td>Unspecified

          </td>

        </tr>

        <tr>

          <th>OS</th>

          <td>Unspecified

          </td>

        </tr>

        <tr>

          <th>Status</th>

          <td>NEW

          </td>

        </tr>

        <tr>

          <th>Severity</th>

          <td>Normal

          </td>

        </tr>

        <tr>

          <th>Priority</th>

          <td>P2

          </td>

        </tr>

        <tr>

          <th>Component</th>

          <td>WebKit Website

          </td>

        </tr>

        <tr>

          <th>Assignee</th>

          <td>webkit-unassigned&#64;lists.webkit.org

          </td>

        </tr>

        <tr>

          <th>Reporter</th>

          <td>beidson&#64;apple.com

          </td>

        </tr>

        <tr>

          <th>CC</th>

          <td>jond&#64;apple.com, timothy&#64;apple.com

          </td>

        </tr></table>

      <p>

        <div>

        <pre>Protector Ref/RefPtrs should have a specified naming style

This came up during patch review of <a class="bz_bug_link 

          bz_status_RESOLVED  bz_closed"

   title="RESOLVED FIXED - Modern IDB: IDBOpenDBRequests that are stop()'ed don't notify the IDBServer of that fact"

   href="show_bug.cgi?id=157448">https://bugs.webkit.org/show_bug.cgi?id=157448</a> but has also come up many times before.

The name for a Ref/RefPtr protector should be &quot;protectedVariableName(variableName)&quot;

Proper naming for a protector should be like the following examples:

RefPtr&lt;Node&gt; protectedThis(this);

Ref&lt;Node&gt; protectedThis(*this);

RefPtr&lt;Node&gt; protectedNode(node);

RefPtr&lt;Connection&gt; protectedOtherConnection(&amp;otherConnection);

RefPtr&lt;Widget&gt; protectedWidget(m_widget);

Improper naming for which there are many examples in WebCore:

RefPtr&lt;Node&gt; protect(this);

RefPtr&lt;Node&gt; protector(this);

RefPtr&lt;Node&gt; self(this);

RefPtr&lt;Element&gt; elementRef(this);

RefPtr&lt;Tree&gt; someWeirdoOtherName(tree);</pre>

        </div>

      </p>

      <hr>

      <span>You are receiving this mail because:</span>

      <ul>

          <li>You are the assignee for the bug.</li>

      </ul>

    </body>

</html>