<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - r200216 fails to build for darwin/gtk: use of undeclared identifier 'm_font'"
href="https://bugs.webkit.org/show_bug.cgi?id=157167#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - r200216 fails to build for darwin/gtk: use of undeclared identifier 'm_font'"
href="https://bugs.webkit.org/show_bug.cgi?id=157167">bug 157167</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=278242&action=diff" name="attach_278242" title="proposed change">attachment 278242</a> <a href="attachment.cgi?id=278242&action=edit" title="proposed change">[details]</a></span>
proposed change
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=278242&action=review">https://bugs.webkit.org/attachment.cgi?id=278242&action=review</a>
<span class="quote">>> Source/WebCore/platform/graphics/FontPlatformData.h:176
>> #if USE(APPKIT)
>
> I'm not familiar with how the Darwin/GTK port is configured. Will this work if it is changed to PLATFORM(MAC)?
>
> If so, I think we should migrate to it; otherwise, I suppose it's fine how it is.</span >
Yes, it will work with PLATFORM(MAC).
No, I don’t agree that we should migrate to it.
We should talk in person about our long term direction for platform #if statements; our goal was to use things like USE(APPKIT) to tell us whether to use an AppKit class like NSFont, rather than something more like PLATFORM(MAC). Maciej was the original visionary for this, although we have not moved very far in that direction.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>