<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Deduplicated initializer lists of BitmapImage constructors."
href="https://bugs.webkit.org/show_bug.cgi?id=157249#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Deduplicated initializer lists of BitmapImage constructors."
href="https://bugs.webkit.org/show_bug.cgi?id=157249">bug 157249</a>
from <span class="vcard"><a class="email" href="mailto:annulen@yandex.ru" title="Konstantin Tokarev <annulen@yandex.ru>"> <span class="fn">Konstantin Tokarev</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=157249#c2">comment #2</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=277869&action=diff" name="attach_277869" title="Patch">attachment 277869</a> <a href="attachment.cgi?id=277869&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=277869&action=review">https://bugs.webkit.org/attachment.cgi?id=277869&action=review</a>
>
> > Source/WebCore/platform/graphics/BitmapImage.cpp:48
> > +BitmapImage::BitmapImage(ImageObserver* observer, bool fromNativeImage)
>
> This approach of taking a boolean is a little bit inelegant, violates our
> coding style rule of not using literal "true" for a mysterious meaning that
> requires reading the code to find out what it means, and also adds a few
> branches to the constructors, but I think it’s OK.</span >
I've got rid of branch in constructor by using template + std::true_type/false_type. Now it should compile to the same code as before, though I understand that it's inelegant.
<span class="quote">>
> > Source/WebCore/platform/graphics/BitmapImage.h:302
> > + int m_repetitionCount { cAnimationNone }; // How many total animation loops we should do.
>
> Not sure why we removed the comment explaining the meaning of
> cAnimationNone. Might be better to move it somewhere rather than removing it
> entirely.</span >
I thought it's not so important after we have initializer. Returned it back now.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>