<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Move ResourceTiming behind a runtime flag"
href="https://bugs.webkit.org/show_bug.cgi?id=157133">bug 157133</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #277852 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Move ResourceTiming behind a runtime flag"
href="https://bugs.webkit.org/show_bug.cgi?id=157133#c27">Comment # 27</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Move ResourceTiming behind a runtime flag"
href="https://bugs.webkit.org/show_bug.cgi?id=157133">bug 157133</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=277852&action=diff" name="attach_277852" title="Patch">attachment 277852</a> <a href="attachment.cgi?id=277852&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=277852&action=review">https://bugs.webkit.org/attachment.cgi?id=277852&action=review</a>
<span class="quote">> LayoutTests/http/tests/performance/performance-resource-timing-entries.html:8
> + var url = "../../resources/square100.png?";
> + url += Math.random();
> + document.write("<img src='" + url + "'>");</span >
This definitely will force reloading. There are better ways of doing this, and we should handle caching better, but this is fine to go in if you file a bug to fix that.
<span class="quote">> LayoutTests/http/tests/performance/performance-resource-timing-entries.html:17
> + var resources = performance.getEntriesByType('resource');
> + for (var i = 0; i < resources.length; ++i) {
> + if (resources[i].name.indexOf("square100") != -1) {</span >
Last time we just made sure that resources.length was 2. Now we iterate it and make sure square100.png?randomnumber is in it. Was the length 2 before because the main resource and the image were expected to be in it?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>