<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147#c64">Comment # 64</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147">bug 156147</a>
from <span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=277702&action=diff" name="attach_277702" title="Patch">attachment 277702</a> <a href="attachment.cgi?id=277702&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=277702&action=review">https://bugs.webkit.org/attachment.cgi?id=277702&action=review</a>
super good start! I don't still look through. Quick comments. I'll look into it more.
And I suggest you to measure Octane code-load. That measures the JS parser's performance.
<span class="quote">> Source/JavaScriptCore/parser/Keywords.table:11
> +await AWAIT</span >
Are async and await keywords? I think they are contextual keywords, correct?
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:357
> + bool isIdent = matchSpecIdentifier();</span >
Nice catch.
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:598
> + if (!(match(IDENT) || match(ASYNC) || match(AWAIT) || match(LET) || match(YIELD)) && !match(OPENBRACE) && !match(OPENBRACKET))</span >
If ASYNC is contextual keyword, we can use matchContextualKeyword function :)
<span class="quote">> Source/JavaScriptCore/runtime/RuntimeFlags.h:35
> + macro(AsyncAwaitEnabled, true)</span >
Nice.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>