<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [FreeType] ASSERTION FAILED: !lookupForWriting(Extractor::extract(entry)).second in FontCache::getVerticalData()"
href="https://bugs.webkit.org/show_bug.cgi?id=157132#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [FreeType] ASSERTION FAILED: !lookupForWriting(Extractor::extract(entry)).second in FontCache::getVerticalData()"
href="https://bugs.webkit.org/show_bug.cgi?id=157132">bug 157132</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=157132#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=277613&action=diff" name="attach_277613" title="Patch">attachment 277613</a> <a href="attachment.cgi?id=277613&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=277613&action=review">https://bugs.webkit.org/attachment.cgi?id=277613&action=review</a>
>
> > Source/WebCore/platform/graphics/FontCache.cpp:326
> > + if (!data->isOpenType()) {
> > + fontVerticalDataCache().remove(addResult.iterator);
> > + return nullptr;
> > + }
>
> This isn’t good, because it will not cache the negative result and so if
> OpenTypeVerticalData::create returns something that is not OpenType then it
> will call OpenTypeVerticalData::create again and again every time this
> function is called. And it will also add/remove an element to/from the hash
> map every time.
>
> I think what we want instead is:
>
> if (!data->isOpenType())
> data = nullptr;
>
> We will cache a nullptr and not call OpenTypeVerticalData::create again next
> time.</span >
Good point!
<span class="quote">> Separately, I also think it’s peculiar that OpenTypeVerticalData::create can
> create something that returns false to isOpenType. There’s some kind of
> naming mistake there. I would think, given its name, that function would
> return nullptr if the data is "not OpenType".</span >
Yes, I was also surprised, maybe we could move the initialization to the create method and simply return nullptr . I'll look at it in more detail.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>