<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r200094): [FreeType] Vertical text is broken after r200094"
href="https://bugs.webkit.org/show_bug.cgi?id=157066">bug 157066</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #277466 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #277466 Flags</td>
<td>review?
</td>
<td>
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #277467 Flags</td>
<td>
</td>
<td>review?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r200094): [FreeType] Vertical text is broken after r200094"
href="https://bugs.webkit.org/show_bug.cgi?id=157066#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r200094): [FreeType] Vertical text is broken after r200094"
href="https://bugs.webkit.org/show_bug.cgi?id=157066">bug 157066</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=277467&action=diff" name="attach_277467" title="Updated patch">attachment 277467</a> <a href="attachment.cgi?id=277467&action=edit" title="Updated patch">[details]</a></span>
Updated patch
I noticed that some tests (the ones using fallbacks) were crashing with this patch. The thing is that I wrongly assumed that the default copy constructor used the assign operator, but since that's not the case we need to keep our own implementation of the copy constructor. The good thing is that now we can use a unique_ptr (FcUniquePtr) for the fallbacks, which simplifies the code a bit more.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>