<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Line error widget showed in the wrong resource"
href="https://bugs.webkit.org/show_bug.cgi?id=150009">bug 150009</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #277277 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Line error widget showed in the wrong resource"
href="https://bugs.webkit.org/show_bug.cgi?id=150009#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Line error widget showed in the wrong resource"
href="https://bugs.webkit.org/show_bug.cgi?id=150009">bug 150009</a>
from <span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=277277&action=diff" name="attach_277277" title="[PATCH] Proposed Fix">attachment 277277</a> <a href="attachment.cgi?id=277277&action=edit" title="[PATCH] Proposed Fix">[details]</a></span>
[PATCH] Proposed Fix
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=277277&action=review">https://bugs.webkit.org/attachment.cgi?id=277277&action=review</a>
<span class="quote">>> Source/WebInspectorUI/UserInterface/Controllers/IssueManager.js:45
>> + return issue.url === sourceCode.url || (issue.sourceCodeLocation && issue.sourceCodeLocation.sourceCode === sourceCode);
>
> I think I should drop the url comparison here, or fallback to it if the sourceCodeLocation is unavailable. Otherwise, two dynamically added <script>s will both show this issue, even if the sourceCode specifically matches one of them.</span >
Maybe we should nullify SourceCode's url for dynamic scripts after we associate things? Though it likely makes sense to just drop this compare too.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>