<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: React.js JSXTransformer produces bogus error locations"
href="https://bugs.webkit.org/show_bug.cgi?id=150010">bug 150010</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #277288 Flags</td>
<td>commit-queue?
</td>
<td>commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: React.js JSXTransformer produces bogus error locations"
href="https://bugs.webkit.org/show_bug.cgi?id=150010#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: React.js JSXTransformer produces bogus error locations"
href="https://bugs.webkit.org/show_bug.cgi?id=150010">bug 150010</a>
from <span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=277288&action=diff" name="attach_277288" title="[PATCH] Proposed Fix">attachment 277288</a> <a href="attachment.cgi?id=277288&action=edit" title="[PATCH] Proposed Fix">[details]</a></span>
[PATCH] Proposed Fix
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=277288&action=review">https://bugs.webkit.org/attachment.cgi?id=277288&action=review</a>
Per IRC discussion let's rename at least the user-visible strings to "Extra Scripts". This will eventually be per-Frame and include InjectedScripts and any other 'eval'uations with a sourceURL.
<span class="quote">> LayoutTests/inspector/model/frame-dynamic-scripts.html:36
> + let mainFrame = WebInspector.frameResourceManager.mainFrame;</span >
With just one frame in play here, this test isn't too good for detecting per-frame behavior. Is this handled by script-resource-relationship.html test? I had expected to see a new test case there.
<span class="quote">> LayoutTests/inspector/model/frame-dynamic-scripts.html:38
> + resolve();</span >
If possible it would be nice to test that the dynamic scripts are cleared when the frame navigates. This might have to happen in an iframe to work around flaky test infrastructure caused by reloading the test page itself.
<span class="quote">> Source/WebInspectorUI/UserInterface/Models/Script.js:48
> + // with the frame as a dynamic script.</span >
Is this so that hyperlinks to the fragment don't try to look it up in the document at 0/0?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>