<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] WebKitWebView should claim the contents size as its natural size"
href="https://bugs.webkit.org/show_bug.cgi?id=156835">bug 156835</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #276902 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] WebKitWebView should claim the contents size as its natural size"
href="https://bugs.webkit.org/show_bug.cgi?id=156835#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] WebKitWebView should claim the contents size as its natural size"
href="https://bugs.webkit.org/show_bug.cgi?id=156835">bug 156835</a>
from <span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=276902&action=diff" name="attach_276902" title="Patch">attachment 276902</a> <a href="attachment.cgi?id=276902&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=276902&action=review">https://bugs.webkit.org/attachment.cgi?id=276902&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1536
> + if (priv->contentsSize == contentsSize)
> + return;
> + priv->contentsSize = contentsSize;</span >
The early check-and-return doesn't help much IMO, since the assignment is the only change of state here, and there's no work or event propagated further if the same size is assigned.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>