<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Fixed compilation with !ENABLE(SVG_FONTS)."
href="https://bugs.webkit.org/show_bug.cgi?id=156850#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Fixed compilation with !ENABLE(SVG_FONTS)."
href="https://bugs.webkit.org/show_bug.cgi?id=156850">bug 156850</a>
from <span class="vcard"><a class="email" href="mailto:ossy@webkit.org" title="Csaba Osztrogonác <ossy@webkit.org>"> <span class="fn">Csaba Osztrogonác</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=276921&action=diff" name="attach_276921" title="Patch">attachment 276921</a> <a href="attachment.cgi?id=276921&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=276921&action=review">https://bugs.webkit.org/attachment.cgi?id=276921&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:15
> + (WebCore::FontCascade::drawGlyphBuffer): Deleted.</span >
Please remove "Deleted." It must be a prepare-changelog bug.
<span class="quote">> Source/WebCore/CMakeLists.txt:2864
> +if (ENABLE_SVG_FONTS)
> + list(APPEND WebCore_SOURCES
> + svg/SVGToOTFFontConversion.cpp
> + )
> +endif ()</span >
We prefer guarding source files to guarding build sytem when it is possible.
Myles, is it OK to add ENABLE(SVG_FONTS) guard to SVGToOTFFontConversion.cpp?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>