<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] WebKitWebView should claim the contents size as its natural size"
href="https://bugs.webkit.org/show_bug.cgi?id=156835#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] WebKitWebView should claim the contents size as its natural size"
href="https://bugs.webkit.org/show_bug.cgi?id=156835">bug 156835</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=156835#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=276902&action=diff" name="attach_276902" title="Patch">attachment 276902</a> <a href="attachment.cgi?id=276902&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=276902&action=review">https://bugs.webkit.org/attachment.cgi?id=276902&action=review</a>
>
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1536
> > + if (priv->contentsSize == contentsSize)
> > + return;
> > + priv->contentsSize = contentsSize;
>
> The early check-and-return doesn't help much IMO, since the assignment is
> the only change of state here, and there's no work or event propagated
> further if the same size is assigned.</span >
Yes, that's the case of this patch, but this is a actually a split of two patches. The other one adds new API to tell the web view to fit its size to the contents, so here I schedule a resize, but only when the contents size have actually changed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>