<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win][IndexedDB] Fix build errors."
href="https://bugs.webkit.org/show_bug.cgi?id=156713#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win][IndexedDB] Fix build errors."
href="https://bugs.webkit.org/show_bug.cgi?id=156713">bug 156713</a>
from <span class="vcard"><a class="email" href="mailto:peavo@outlook.com" title="peavo@outlook.com">peavo@outlook.com</a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=156713#c14">comment #14</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=276760&action=diff" name="attach_276760" title="Patch">attachment 276760</a> <a href="attachment.cgi?id=276760&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=276760&action=review">https://bugs.webkit.org/attachment.cgi?id=276760&action=review</a>
> </span >
Thanks for reviewing!
<span class="quote">>
> > Source/WebCore/bindings/js/JSDOMWindowBase.h:23
> > +#include "DOMWindow.h"
>
> Is this really necessary? What error does this prevent? Can we not forward
> declare things? Including more headers in a header like this makes the
> build slower.
> </span >
I get the error:
wtf/PassRefPtr.h(42): error C2027: use of undefined type 'WebCore::DOMWindow'
PassRefPtr<DOMWindow> is used in JSDOMWindowBase.h, but this fails to compile since the class DOMWindow is only forward declared here.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>