<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - calling super() a second time in a constructor should throw"
href="https://bugs.webkit.org/show_bug.cgi?id=151113#c50">Comment # 50</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - calling super() a second time in a constructor should throw"
href="https://bugs.webkit.org/show_bug.cgi?id=151113">bug 151113</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=151113#c49">comment #49</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=276749&action=diff" name="attach_276749" title="Patch">attachment 276749</a> <a href="attachment.cgi?id=276749&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=276749&action=review">https://bugs.webkit.org/attachment.cgi?id=276749&action=review</a>
>
> >> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1103
> >> + constantWasSet = true;
> >
> > Doesn't setConstant already assign to this variable for us?
>
> I did as do in another 'case's. Anyway constantWasSet is local variable
> declared just above of the switch/case construction, but In setConstant we
> assign m_foundConstants of m_state object.
>
> >> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:4440
> >> + m_jit.comparePtr(JITCompiler::Equal, value.gpr(), TrustedImm32(JSValue::encode(JSValue())), result.gpr());
> >
> > This should be TrustedImm64
>
> There is no function for TrustedImm64 in MacroAssembler.h, only for
> TrustedImm32. Do I need create new one?
> <a href="https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/assembler/">https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/assembler/</a>
> MacroAssembler.h#L998</span >
Right. I think you want TrustedImmPtr which is 64 bits on 64bit architectures.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>