<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - calling super() a second time in a constructor should throw"
href="https://bugs.webkit.org/show_bug.cgi?id=151113#c41">Comment # 41</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - calling super() a second time in a constructor should throw"
href="https://bugs.webkit.org/show_bug.cgi?id=151113">bug 151113</a>
from <span class="vcard"><a class="email" href="mailto:gskachkov@gmail.com" title="GSkachkov <gskachkov@gmail.com>"> <span class="fn">GSkachkov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=276660&action=diff" name="attach_276660" title="Patch">attachment 276660</a> <a href="attachment.cgi?id=276660&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=276660&action=review">https://bugs.webkit.org/attachment.cgi?id=276660&action=review</a>
<span class="quote">>> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1101
>> + if (!(child.m_type & SpecEmpty)) {
>
> You also want this one to check child.m_type && ...</span >
Done. What do I need to do to cover this code by tests?
<span class="quote">>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:4419
>> + m_jit.comparePtr(JITCompiler::Equal, value.gpr(), TrustedImm32(ValueEmpty), result.gpr());
>
> I think this is probably correct, but I think it's way clearer as:
> m_jit.comparePtr(Equal, value.gpr(), TrustedImm64(JSValue::encode(JSValue())), result.gpr())</span >
Done by following code m_jit.comparePtr(JITCompiler::Equal, value.gpr(), TrustedImm32(JSValue::encode(JSValue())), result.gpr())
<span class="quote">>> Source/JavaScriptCore/jit/JITOpcodes.cpp:185
>> + compare64(Equal, regT0, TrustedImm32(ValueEmpty), regT0);
>
> ditto.</span >
Done</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>