<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147#c58">Comment # 58</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147">bug 156147</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=276565&action=diff" name="attach_276565" title="Patch">attachment 276565</a> <a href="attachment.cgi?id=276565&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=276565&action=review">https://bugs.webkit.org/attachment.cgi?id=276565&action=review</a>
A couple fly by comments. Will look more later.
<span class="quote">> Source/JavaScriptCore/builtins/AsyncFunctionPrototype.js:33
> + const Completed = -1;
> + const Executing = -2;
> +
> + const NormalMode = 0;
> + const ThrowMode = 2;</span >
Yusuke recently made these intrinsic values in byte code generator for generatorResume. I think we should do the same here for consistency.
<span class="quote">> Source/JavaScriptCore/runtime/JSAsyncFunction.h:1
> +/*</span >
Do we really need a separate class for this? It appears that this adds no new fields.
I haven't looked in great detail of where this is used.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>