<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win][IndexedDB] Fix build errors."
href="https://bugs.webkit.org/show_bug.cgi?id=156713#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win][IndexedDB] Fix build errors."
href="https://bugs.webkit.org/show_bug.cgi?id=156713">bug 156713</a>
from <span class="vcard"><a class="email" href="mailto:peavo@outlook.com" title="peavo@outlook.com">peavo@outlook.com</a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=156713#c4">comment #4</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=276667&action=diff" name="attach_276667" title="Patch">attachment 276667</a> <a href="attachment.cgi?id=276667&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=276667&action=review">https://bugs.webkit.org/attachment.cgi?id=276667&action=review</a>
>
> cool!
> </span >
Thanks for reviewing :)
<span class="quote">> > Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:44
> > - return std::make_unique<MemoryBackingStoreTransaction>(backingStore, info);
> > + return std::unique_ptr<MemoryBackingStoreTransaction>(new MemoryBackingStoreTransaction(backingStore, info));
>
> This shouldn't be needed.
> </span >
I get a compile error without this:
error C2248: 'WebCore::IDBServer::MemoryBackingStoreTransaction::MemoryBackingStoreTransaction': cannot access private member declared in class 'WebCore::IDBServer::MemoryBackingStoreTransaction
Maybe we should fix this in another way?
<span class="quote">>
> > Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1188
> > - auto callback = [this, self, refTransaction](const IDBError& error) {
> > + ErrorCallback callback = [this, self, refTransaction](const IDBError& error) {
>
> This shouldn't be needed.
> </span >
I get an error without this:
error C2668: 'WebCore::IDBServer::UniqueIDBDatabase::storeCallback': ambiguous call to overloaded function
<span class="quote">> > Source/WebKit/win/storage/WebDatabaseProvider.cpp:45
> > + sprintf_s(databaseDirectory, MAX_PATH, "%s\\%s", appDataDirectory, executableName);
>
> On Mac we use .../WebKit/Databases/___IndexedDB. We should probably do
> something similar here.</span >
I will update the path :)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>